Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move {min,max}_payment_size_msat into opening fee params #186

Open
JssDWt opened this issue Feb 15, 2024 · 0 comments · May be fixed by #195
Open

Move {min,max}_payment_size_msat into opening fee params #186

JssDWt opened this issue Feb 15, 2024 · 0 comments · May be fixed by #195

Comments

@JssDWt
Copy link
Collaborator

JssDWt commented Feb 15, 2024

In LSPS2, the fields min_payment_size_msat and max_payment_size_msat are part of the get_info response. BitcoinAndLightningLayerSpecs/lsp#82 moves them into the opening_fee_params.

We'll still have to support opening_fee_params that do not contain these fields. The only place for that as far as I can tell is the paramsHash function in the opening service. It can try to validate with those fields first and then without as well to ensure backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant