move min/max payment size into opening fee params #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
force-pushed
the
jssdwt-min-max-payment-size
branch
2 times, most recently
from
7c60e65
to
8893e7a
Compare
|
Generating an opening fee params hash that includes min/max payment size won't work, because the current clients won't send back these fields yet. So the hash has to exclude these fields. But then we can't trust these fields to be correct when passed in by the client. |
JssDWt
force-pushed
the
jssdwt-min-max-payment-size
branch
from
0d138c6
to
b3781f4
Compare
This was referenced Feb 23, 2024
|
Closing, because these fields will only be included in LSPS2. Will add another PR to replace this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186
This PR requires the operator to update their
new_channel_paramstable to contain themin_payment_size_msatandmax_payment_size_msatfields. They are deprecated in the node configuration (however, still good to set the values there as well until they are removed from the code).