Skip to content

Commit

Permalink
Refactor base code
Browse files Browse the repository at this point in the history
* drop the ProgressReporterFacade interface
* minor refactor of other typos
  • Loading branch information
breezerider committed Apr 1, 2024
1 parent b4efee4 commit 90d9f21
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions pkg/common/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import (
"net/url"
"strings"
"time"

"github.com/schollz/progressbar/v3"
)

type (
Expand All @@ -26,21 +24,12 @@ type (
// * StoreFile to store data to a given URI.
// * RemoveFile to remove files under a given URI.
StorageBackend interface {
GetFileInfo(uri *url.URL) (*FileInfo, error)
GetFileInfo(*url.URL) (*FileInfo, error)
ListFiles(*url.URL) ([]FileInfo, error)
StoreFile(io.ReaderAt, int64, *url.URL) error
RemoveFile(*url.URL) error
}

// ProgressReporterFacade is a generic interface to setting up progress reporting:
// enable and disable progress reporting and set progressbar settings.
ProgressReporterFacade interface {
GetProgressEnabled() bool
SetProgressEnabled(bool)
GetProgressbarOptions() []progressbar.Option
SetProgressbarOptions(options ...progressbar.Option)
}

// DummyBackend defines a dummy backend.
DummyBackend struct {
dummyFiles []FileInfo
Expand Down Expand Up @@ -90,7 +79,7 @@ func (fi *FileInfo) Modified() time.Time {
return fi.modified
}

// Modified returns last modified date of the file object.
// IsFile returns true if this object represents a file.
func (fi *FileInfo) IsFile() bool {
return fi.isfile
}
Expand Down

0 comments on commit 90d9f21

Please sign in to comment.