Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme of the "pencil" Edit location dialog background follows first location instead of app theme #1107

Closed
5 tasks done
elydpg opened this issue Jun 9, 2024 · 2 comments · Fixed by #1149
Closed
5 tasks done
Labels
Bug Something isn't working Open to contributions This issue is open to the community for implementation Priority: low Issues that have one or more workarounds available, or fall a bit outside the scope of a weather app
Milestone

Comments

@elydpg
Copy link

elydpg commented Jun 9, 2024

Steps to reproduce

  1. Make sure the list of locations is empty and the app theme is set to follow system
  2. Add two locations, the first in daytime the second in nighttime
  3. Go to the nighttime location
  4. Press the pencil icon
  5. Toggle system dark theme
  6. Press the pencil icon again

Expected behavior

The theme of the pencil icon should follow the system theme

Actual behavior

The theme follows the day/night theme of the first location

Weather source used

N/A

Breezy Weather version

5.2.4 standard

Android version

12

Device

Samsung Galaxy s10e

Other details

Below is a demonstration of the issue in action. Note that I am using pre existing locations

Screen_Recording_20240610_012659_Breezy.Weather_1.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open OR closed issue.
  • I checked that my issue is not covered in the Frequently Asked Questions document.
  • I have updated the app to version 5.2.4 or later and I can reproduce the issue in this version.
  • I wrote my request in English, and any screenshot I attached are also in English (language can be changed from Settings > Appearance), unless my issue only happens with a specific language. I can write in my native language under the English text, if necessary.
  • I understand that this app is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY, so I may not get a positive reply to my request, if any at all.
@elydpg elydpg added Bug Something isn't working Needs review Issue that need to be analyzed (reproduced for a bug, take a decision for an idea, etc) labels Jun 9, 2024
@papjul
Copy link
Collaborator

papjul commented Jun 10, 2024

You're not talking about the pencil icon color but of the "Edit location" dialog background color, right?

@elydpg elydpg changed the title Theme of the "pencil" icon follows first location instead of app theme Theme of the "pencil" icon screen follows first location instead of app theme Jun 10, 2024
@elydpg
Copy link
Author

elydpg commented Jun 10, 2024

Yes; I edited the title to make that more clear

@elydpg elydpg changed the title Theme of the "pencil" icon screen follows first location instead of app theme Theme of the "pencil" Edit location dialog background follows first location instead of app theme Jun 10, 2024
@papjul papjul added Open to contributions This issue is open to the community for implementation Priority: low Issues that have one or more workarounds available, or fall a bit outside the scope of a weather app and removed Needs review Issue that need to be analyzed (reproduced for a bug, take a decision for an idea, etc) labels Jun 10, 2024
papjul added a commit that referenced this issue Jun 22, 2024
@papjul papjul added this to the v5.2.5 milestone Jun 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Open to contributions This issue is open to the community for implementation Priority: low Issues that have one or more workarounds available, or fall a bit outside the scope of a weather app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants