Fix theme issues in AlertActivity and PollenActivity #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed day/night mode is used - Fix theme for AlertActivity - Fix color of status bar for PollenActivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1138 by retrieving the weather data for the location to calculate the correct "rise progress" of the sun. Previously it used defaults (sunrise at 6 am, sunset at 6 pm) as a fallback which caused the issue described in #1138.
The PR also fixes an issue with the color of the status bar in the PollenActivity when the location-based day/night mode is enabled. It now uses the same approach as PR #1022.
Tested on devices with Android 9 and 14.
screenshots
Tested with locations where the sun was still up. Location-based day/night mode was enabled and the dark theme was used in the app.
Currently, the changes in the AlertActivity can be tested with the location "Oral, Kazakhstan" using WMO as source for alerts.