Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on deploy #47

Closed
gregmsanderson opened this issue Jul 25, 2018 · 5 comments
Closed

Error on deploy #47

gregmsanderson opened this issue Jul 25, 2018 · 5 comments

Comments

@gregmsanderson
Copy link

Given the message, this issue is with the underlying serverless framework, but having edited a single character in bref (related to the progress bar), deploys now all fail. It mentions a Process.php so is that the file that calls serverless to do the deploy on its behalf?

Not very helpfully it does not show any error output, just complains about malformed XML. Given it happens at the end, the point where the file is uploaded to S3, it could be an issue with that? Strange. This is what happens, in case anyone else has had this. If not I can close and maybe take it up with serverless. Strange because I haven't changed the version of it and it was working earlier!

deploy-error

@gregmsanderson
Copy link
Author

Yes, it does seem to be an issue with the underlying system used to deploy. Annoyingly nobody seems to have found a fix. Someone reported it with serverless but got no response: https://forum.serverless.com/t/cant-deploy-s3-complains-of-invalid-xml/3384

@gregmsanderson
Copy link
Author

gregmsanderson commented Jul 26, 2018

Interestingly I edited the serverless.yml file created by init to include some more details. And then the deploy works.

So I'm thinking one of these may be causing it given that was the only file I just changed, and it now works. Unless it is some random fault with the underlying SDK used to upload to S3, however that seems less likely.

So I'd suggest an enhancement: as part of init, specify details like the region too. This is what I have and the deploy is (currently) working:

edited-serverless-yml

Not entirely sure how much of these bref uses. Or whether - since it uses serverless behind-the-scenes - it can use the same ones serverless does.

@mnapoli
Copy link
Member

mnapoli commented Jul 29, 2018

I'm not sure I understand if the problem is with Bref here. If you start a new project, do bref init and bref deploy (without changing serverless.yml) does that work?

@gregmsanderson
Copy link
Author

It seems to be a problem with serverless ... but (maybe) caused by the yml (and the yml is created by bref). I wasn't able to recreate it and the guy on the serverless forum did not get a response either. It may be entirely unrelated to the yml - I just noticed that after I started getting that error on deploy, I defined more values in the yml (the one created by init didn't include them) as part of randomly trying stuff to fix it ... and then the deploy worked. Weird! Can probably close.

@mnapoli
Copy link
Member

mnapoli commented Jul 29, 2018

OK let's reopen if we have more info. Thanks!

@mnapoli mnapoli closed this as completed Jul 29, 2018
brefphp-bot pushed a commit to brefphp-bot/bref that referenced this issue Jan 18, 2022
Attempt with new docker-compose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants