Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for extension bcmath #95

Closed
oppiansteve opened this issue Nov 22, 2018 · 3 comments
Closed

Request for extension bcmath #95

oppiansteve opened this issue Nov 22, 2018 · 3 comments
Milestone

Comments

@oppiansteve
Copy link

This is needed for (some?) watchers in Laravel Telescope. (At least the EventWatcher).

Still working on getting Telescope usable, so not an urgent request as may not be possible anyway (or at least not for the watchers that need it).

I'm mostly getting Telescope working as a reasonably complex app (along with Nova) to see where the pain points are with Bref.

@mnapoli
Copy link
Member

mnapoli commented Nov 22, 2018

You can send a pull request on the Dockerfile that is used to build the binary and the extensions: https://github.com/mnapoli/bref/blob/master/bin/php/Dockerfile#L36

If it's installed through pecl there is a pecl install line below line 36.

@oppiansteve
Copy link
Author

It looks like I just need to add the flag --enable-bcmath then do the same for the extension bcmath as you do for intl. (And update the README.md).

I'll just duplicate the extension build script segment of instructions for now, as I'm not sure of the most efficient way to do the same RUN commands but over a list of different WORKDIRs (without killing the layer caching?). (Bit new to this). Unless you have a better way to do that.

Just testing this now (over very slow wifi in a Starbucks in Hamburg).

oppiansteve added a commit to oppiansteve/bref that referenced this issue Nov 22, 2018
@mnapoli mnapoli added this to the 0.3 milestone Jan 19, 2019
@mnapoli
Copy link
Member

mnapoli commented Jan 19, 2019

We defined a list of pre-installed extensions for v0.3 (see https://bref.sh/docs/environment/php.html), bcmath isn't built by default.

If you want to use it you will have to compile it yourself in your lambda and enable it with a php.ini (https://bref.sh/docs/environment/php.html should explain a bit more).

I'll close this issue for now.

@mnapoli mnapoli closed this as completed Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants