Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.1 for ARM layers #1360

Merged
merged 1 commit into from Dec 15, 2022
Merged

Support PHP 8.1 for ARM layers #1360

merged 1 commit into from Dec 15, 2022

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented Dec 15, 2022

@mnapoli mnapoli added this to the 2.0 milestone Dec 15, 2022
@mnapoli mnapoli self-assigned this Dec 15, 2022
@mnapoli mnapoli merged commit 79ee491 into v2 Dec 15, 2022
@mnapoli mnapoli deleted the arm-81 branch December 15, 2022 14:48
@aran112000
Copy link
Contributor

The PHP 8.1 ARM FPM layers appear to be missing cURL so don't actually run correctly at the moment:

Fatal error: Uncaught Error: Call to undefined function Bref\Runtime\curl_init() in /opt/bref/php-fpm-runtime/vendor/bref/bref/src/Runtime/LambdaRuntime.php:111
Stack trace:
#0 /opt/bref/php-fpm-runtime/vendor/bref/bref/src/Runtime/LambdaRuntime.php(80): Bref\Runtime\LambdaRuntime->waitNextInvocation()
#1 /opt/bref/php-fpm-runtime/vendor/bref/php-fpm-runtime/src/bootstrap.php(41): Bref\Runtime\LambdaRuntime->processNextEvent(Object(Bref\FpmRuntime\FpmHandler))
#2 {main}
thrown in /opt/bref/php-fpm-runtime/vendor/bref/bref/src/Runtime/LambdaRuntime.php on line 111

@mnapoli
Copy link
Member Author

mnapoli commented Dec 20, 2022

Oh interesting, it seems our tests are not catching it: https://github.com/brefphp/aws-lambda-layers/blob/main/tests/test_2_extensions.php#L8

I'll investigate that, thanks @aran112000!

@mnapoli
Copy link
Member Author

mnapoli commented Dec 20, 2022

@aran112000 the new beta was kind of broken actually, I pushed a new beta to fix this (tested ARM PHP 8.1): https://github.com/brefphp/bref/releases/tag/2.0.0-beta3

Thank you!

@aran112000
Copy link
Contributor

You're a star - thanks so much for diagnosing and getting a new release pushed out so quickly!! Just rolled out an internal service on it as a test and it's working perfectly (PHP 8.1 on Graviton) 🚀

@mnapoli
Copy link
Member Author

mnapoli commented Dec 20, 2022

Just rolled out an internal service on it as a test and it's working perfectly (PHP 8.1 on Graviton) 🚀

That is awesome feedback, thank you for sharing!

@aran112000
Copy link
Contributor

The performance of these new ARM layers on Bref 2 is insane! We've upgraded another workload this afternoon and here are the performance results looking at the total Lambda duration (Orange: AVG, Blue: MIN):

image

If you can't guess, the changes rolled out 13:35.

What's more crazy, is we reduced the allocated memory from 512 to 360 as well! 🚀

@mnapoli
Copy link
Member Author

mnapoli commented Dec 21, 2022

@aran112000 wooow that's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants