Fix #1593 WebsocketEvent getRegion() not returning correct region for custom domains
#1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion when using custom domain.
Shkeats
changed the title
WebsocketEvent getRegion() not returning correct region for custom domains
|
It seems the tests are failing, they might need some update. |
|
@mnapoli updated with the env set for the test suite. I'm not sure if it's fine to assume that it's always set and never returning false in the real world, I think we do that elsewhere in the project for lambda environment variables like |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1593 using the
AWS_REGIONenv variable set in the lambda runtime.