Support malformed multipart body #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example body containing broken array keys like `key0[key1][key2][`
mnapoli
force-pushed
the
multipart-arrays-malformed
branch
from
11849a0
to
350788d
Compare
mnapoli
commented
Jan 31, 2024
| @@ -383,7 +401,7 @@ public function test POST request with multipart file uploads(int $version | |||
| --testBoundary--\r | |||
| "; | |||
| $this->assertBody($body); | |||
| $this->assertParsedBody([]); | |||
| $this->assertParsedBody(null); | |||
There was a problem hiding this comment.
Side-effect bugfix (minor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example body containing broken array keys like
key0[key1][key2][.We use
parse_strto ensure keys are parsed just like native PHP would.