Allow PHP archive to provide a php.ini file #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing, see #26 (comment) |
brefphp-bot
pushed a commit
to brefphp-bot/bref
that referenced
this pull request
Nov 18, 2021
Fix branch name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bref allow us to provide an archive containing our version of PHP, that's why I think we should also be able to provide the related php.ini file.
Bref install a default php.ini file containing opcahe configuration but there is no guaranty that related extensions will be available in the archive.
Just to keep bref working with existing archives, I left the default php.ini as a fallback if there's no php.ini file in the archive.
As mentioned in #26, this would allow us to embed more extensions in the archive and load them.
fix #26