Rebase: Expose the request context in the FPM layer via a global variable #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This request context is needed if a user is using the authentication type of IAM_ROLE, when a user auths through Api Gateway it will then authorise the user and pass their information (securely as request context). At the moment the file misses this so a php function cant use the authorised details correctly.
This was referenced Jan 26, 2020
|
Thanks! I'll add documentation after the merge. |
|
Thank you for merging |
mnapoli
added a commit
that referenced
this pull request
Jan 28, 2020
mnapoli
added a commit
that referenced
this pull request
Feb 14, 2023
Rebase: Expose the request context in the FPM layer via a global variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #501, used JSON instead of adding many global variables.
It is not possible to add an array, because it needs to be serialised and sent to PHP FPM.
This will fix #506 and fix #500