Support for HTTP API #602

[victormacko]

I've added in support for HTTP v2.0 payloads primarily to have Bref give a "works out of the box" experience when linking Lambda with the new HTTP API via the AWS Console, rather than having to switch back to 1.0 in the integrations section in the console.

Also - i'm pretty keen to start using the new API Gateway HTTP option so hopefully this helps getting Bref one more step closer to it :) ... this should also help with issue #602

I'd started looking at the tests to add but was wanting some guidance on it first -- I think the best approach is to add another FpmHandlerTest class for the v2 payloads as most of the test-cases are probably going to be worth testing...

The changes i've made cover;

• Adding a 'payloadVersion' in the request & response classes (the response classes needed it as the multi-header option doesn't exist in v2)
• Handling cookies in the FpmHandler & HttpRequestEvent classes (they're passed in separately and not as a HTTP Header as far as I can tell)
• Updated how the method is obtained (var names have changed)
• Updated how the path is obtained (var names have changed)
• Updated how the query-string is obtained (var names have changed) (the multiValueQueryStringParameters no longer exists either in v2)

The unit-tests all pass, but they haven't as yet been updated to test for the v2 payloads -- need some guidance (as above) on this before spending time on getting that sorted.

[mnapoli]

Thank you, this looks really great! (I have added quite a few of inline comments, but these are mostly details, the whole PR looks really good!)

As for the tests, yes, this is a tricky one. Let me have a look at what's best 🤔

[mnapoli]

Regarding the tests, here is what I noted:

• Bref\Test\Event\Http\HttpResponseTest: unit test, should be easy to update
  You can duplicate existing tests and name them with v1 and v2 in the test name to differentiate. If some tests are identicals (the behavior is identical between v1 and v2), then don't duplicate the test.
• Bref\Test\Event\Http\CommonHttpTest: another unit test for the requests, this one is a bit more complex because it's an abstract class.
  This class uses JSON examples for the tests. What you can do is duplicate all JSON files to have them in v1 and v2 formats.

I have pushed a new commit to your pull request to start adding tests in CommonHttpTest. Hopefully that should help you move forward. If you still don't understand, let me know and I'll try to find time to complete them.

[victormacko]

Ace, thanks so much for your help on those tests -- i'll have a proper look through it once i've made the other code changes and got them committed.

[mnapoli]

Awesome thanks!

[victormacko]

RE tests @mnapoli , the Bref\Test\Handler\FpmHandlerTest doesn't have the 'version' set on any of the data it's testing ... do you have a preferred approach ... default to v1 in the HttpRequestEvent or just add in the 'version' to each of the tests? (not sure if you wanted to keep the tests small or not).

I'll finish tackling the v2 JSON files tomorrow -- i'm almost done :)

[mnapoli]

Regarding FpmHandlerTest yes keep v1, that's definitely sufficient given how much is covered elsewhere. I'll have a look at the rest ASAP, that's awesome.

[mnapoli]

At first look that sounds really good. The build seems to be failing, but we are definitely on the right track.

[victormacko]

Ace!
I've updated the FPM tests so there's only 4 overall failing (just 2 issues really);

• 2 for the multi-headers (AWS concatenates multi-headers a single string, separated by a ',' (not url-encoding ... so commas inside user-agent headers, etc may get handled incorrectly if we were to try and separate them out just using the ',')
• 2 for multi-query-string (eg. a=abc&a=def) ... the tests expect the rawQueryString to be url-encoded ... and using parse_str & http_build_query together don't handle int-indexed arrays as well as the unit-tests expect :/

Hope that helps -- not quite sure on what approach to take for those two.

[mnapoli]

OK @victormacko I think we are good here!

[mnapoli]

Thank you so much for all that work, that is massive. Time to try that!