Bref init: Automatically git add bref.php serverless.yml + gitignore /.bref/
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdechenaux
commented
Oct 7, 2018
| if (getenv('AWS_ACCESS_KEY_ID') === false || getenv('AWS_SECRET_ACCESS_KEY') === false) { | ||
| // Credentials are not configured with environment variables, check aws cli | ||
| if ($exeFinder->find('aws') !== null) { |
There was a problem hiding this comment.
This is not needed, Process will exits with status 1 if not found. It simplifies the block :)
staabm
reviewed
Oct 7, 2018
| * - add /.bref/ to .gitignore | ||
| */ | ||
| if ((new Process('git rev-parse --is-inside-work-tree'))->run() === 0) { | ||
| (new Process('git add bref.php serverless.yml'))->run(); |
There was a problem hiding this comment.
this could also be combined into a single process command, with &&
There was a problem hiding this comment.
Yes, but I think it's harder to read/understand
|
This is perfect thanks! |
jvis
pushed a commit
to jvis/bref
that referenced
this pull request
Nov 1, 2018
…gnore Bref init: Automatically `git add bref.php serverless.yml` + gitignore /.bref/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
496a990 is a little extra, related to #68 🙊