Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable HTTP/2 for CURL #740

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Enable HTTP/2 for CURL #740

merged 3 commits into from
Sep 9, 2020

Conversation

shouze
Copy link
Contributor

@shouze shouze commented Sep 8, 2020

Fixes #727

mnapoli
mnapoli approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added an inline suggestion to improve maintenance.

runtime/base/base.Dockerfile Show resolved Hide resolved
@mnapoli
Update runtime/base/base.Dockerfile
e1214ef 
Co-authored-by: Matthieu Napoli <matthieu@mnapoli.fr>
shouze
shouze commented Sep 9, 2020
View reviewed changes
runtime/base/base.Dockerfile Outdated Show resolved Hide resolved
@mnapoli
Copy link
Member

mnapoli commented Sep 9, 2020

Thanks!

@mnapoli mnapoli merged commit 07817b0 into brefphp:master Sep 9, 2020
@shouze shouze deleted the patch-3 branch September 9, 2020 15:07
@shouze
Copy link
Contributor Author

shouze commented Sep 9, 2020

😉 @atbreuer11 will be happy soon!

@atbreuer11
Copy link

@shouze Your amazing! - looking forward to testing this out.

@mnapoli mnapoli mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnapoli mnapoli mnapoli approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable HTTP/2 for CURL
3 participants
@shouze @mnapoli @atbreuer11