Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not update configs with AWS tokens #123

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mchristie
Copy link

Although it's recommended to use AWS roles that's not always possible.

If the application is setting AWS keys and secrets with credentials which do not need an AWS token, adding the token in from the function role will cause the credentials to become invalid.

This PR adds a config option which disables updating the AWS configs with AWS_SESSION_TOKEN

config/bref.php Outdated Show resolved Hide resolved
src/BrefServiceProvider.php Outdated Show resolved Hide resolved
src/BrefServiceProvider.php Outdated Show resolved Hide resolved
config/bref.php Outdated Show resolved Hide resolved
config/bref.php Outdated Show resolved Hide resolved
config/bref.php Outdated Show resolved Hide resolved
@mchristie mchristie requested a review from tillkruss June 20, 2023 14:08
@deleugpn
Copy link
Member

deleugpn commented Jul 2, 2023

My take on this is that the behavior of the adapter is to casually adjust Laravel's default installation for a quick drop-in replacement for Lambda. If you're deploying your project into Lambda it's an opportunity to replace secret keys with IAM Roles.
However, if you have reasons to stick with access key / secret key, all you'd have to do is change the name of the driver / connection you're using. E.g. if instead of using the s3 disk on your filesystems config, you could just name it something else like bucket or storage or the business meaning behind the files that get stored there. Anything that is not the default laravel installation configuration wouldn't be touched by the Bridge and you'd be free to configure it however you feel like it.
It seems like a low effort on the user's part and one less configuration that Bref would have to maintain.

@mnapoli
Copy link
Member

mnapoli commented Jul 2, 2023

Yeah, I'd tend to agree with @deleugpn as this is a niche use case. I'm not against merging this, but I'm not especially pushing for it. I'll let you guys decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants