Make sure view.compiled is correctly defined + tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the quick PR! |
| $this->assertEmpty($handler->getErrorOutput()); | ||
| } | ||
|
|
||
| public function test make an error without view compiled path() |
There was a problem hiding this comment.
are these tests actually getting run? method names cannot have spaces in. it's invalid syntax.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sounds like a terrible idea. Is certainly against the Symfony code style guide to do that. 🤣
mnapoli
pushed a commit
that referenced
this pull request
Mar 10, 2023
* Improve CI * Do not export Codespell config * Fix Spelling workflow * rename --------- Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
A problem reported by a laravel-bridge user on bref's Slack. This fix is to make sure the
view.compiledvariable is correctly defined and, if not, it's returning an understandable error.I try to add to test case, BUT, I did not successfully reproduce the error encounter by the user. Laravel is throwing an error before I reach bref's Service Provider.