Parse Cookies before sending to AWS Runtine Interface #11
Conversation
Co-authored-by: Denis Alustau <denisalustau@gmail.com>
|
This isn't ready yet. Although it fixes the issue on the ExpressJS side, the way the cookies arrive on Bref breaks at https://github.com/brefphp/bref/blob/master/src/Event/Http/HttpRequestEvent.php#L192-L195 so it's likely we're not being compatible with API Gateway V2 here. We need to find a way to send the cookies exactly like Amazon does. |
Co-authored-by: Denis Alustau <denisalustau@gmail.com>
| @@ -37,12 +37,14 @@ export function httpRequestToEvent(request: Request): APIGatewayProxyEventV2 { | |||
| const bodyString = request.method === 'GET' ? '' : request.body.toString('utf8'); | |||
| const shouldSendBase64 = request.method === 'GET' ? false : bodyString.includes('Content-Disposition: form-data'); | |||
|
|
|||
| const cookies = request.headers.cookie ? request.headers.cookie.split('; ') : []; | |||
There was a problem hiding this comment.
I'm afraid this might break if a cookie contains the ; character, could you add a test to cover that scenario?
There was a problem hiding this comment.
cookies, like most things HTTP, need to be URL-encoded.
This is a cookie with ;
which is what makes it safe to do the split on ;.
I'm trying to understand the tests to see if I can add one
There was a problem hiding this comment.
🤦 of course sorry, that makes sense!
Co-authored-by: Denis Alustau <denisalustau@gmail.com>
|
@mnapoli tests added! |
|
Awesome thanks! |
Without parsing cookies, the attribute
request.cookiesis always empty