Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CreatureType to replace use of CMarkup library #21

Closed
3 tasks done
bregma opened this issue Nov 30, 2017 · 0 comments
Closed
3 tasks done

Refactor CreatureType to replace use of CMarkup library #21

bregma opened this issue Nov 30, 2017 · 0 comments

Comments

@bregma
Copy link
Owner

bregma commented Nov 30, 2017 •
edited
Loading

This is a roll-up issue for putting infrastructure in place for further work replacing CMarkup and moving more data into loaded files for improved modding support.

The following tasks must be completed to resolve this issue.

  • Replace the global creaturetypes array with a suitable CreatureType cache object
  • replace the use of CMarkup with TinyXML2 for reading the CreatureType definitions file(s)
  • add unit tests for CreatureType
This was referenced Nov 30, 2017
Closed
Merged
@bregma bregma closed this as completed in #22 Dec 3, 2017
bregma added a commit that referenced this issue Dec 3, 2017
@bregma
Integrate TimyXML2
22e5ed9 
Integrate the TinyXML2 library as a first step to replacing CMarkup due to licensing issues.

Also replace the use of CMarkup in the CreatureType module and add unit tests for the same.

Closes #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bregma