Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drop everything after "(" inside C++ template parameters #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamnovak
Copy link

This should eliminate weird partial things like
std::function<void from flame graphs.

Fixes #120
Fixes #192
Fixes #214

This should eliminate weird partial things like
`std::function<void` from flame graphs.

Fixes brendangregg#120
Fixes brendangregg#192
Fixes brendangregg#214
@christoph-cullmann
Copy link

Tested here at AbsInt, very useful to avoid strange cuttings for template names.

@Hi-Angel
Copy link

Note: since the project doesn't have an active maintainer to address issues or even PRs, there's an active analogous project that you can use. It's written in Rust. Screenshot for a C++ testcase from this project:

Screenshot_20191127_183207

@brendangregg
Copy link
Owner

I worked on this project last month. These PRs that change the regexps require a lot of testing, and I've been meaning to rewrite the testing framework before merging them. That's a lot of work but will pay off for future regexp changes.

@pizzard
Copy link

pizzard commented Dec 20, 2019

This works great for me.

@SoftwareApe
Copy link

SoftwareApe commented May 25, 2020

@Hi-Angel I like the much cleaner interface, however with the rust tool (v0.3.0 installed using cargo install flamegraph) I get the exact same "function<bool" partial function names.

EDIT: Now fixed in inferno v0.9.7, which should at some point be referenced in flamegraph-rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment