Support AsyncProfiler generated stack trace #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QuantumBear, can you please provide examples of async-profiler output? |
|
Thanks, but this shouldn't support async-profiler and break other formats (unannotated perf) at the same time. If someone can provide some asyncprofiler output for the test directory (or I can go generate some) I can then test that flamegraph still works for everyone. I think there's a good chance it well, but I want to test it first. |
|
Now async-profiler offered it own way to generate flamegraph, I think this PR should be closed. Thanks for you guys help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlameGraph can support async-profiler (https://github.com/jvm-profiling-tools/async-profiler) output to generate svg file.