Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter intended to exclude perf's own writes. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kelleyk
Copy link

@kelleyk kelleyk commented Dec 14, 2015

I noticed that the write_workaround code paths weren't working as intended (which is bad, since perf recording its own writes causes something of a feedback loop).

The idea behind the trick being used is that sh substitutes its PID for $$; then exec replaces sh with perf (keeping the same PID), so we have managed to put perf's own PID in the filter, which successfully excludes perf's writes. (Yay!)

This patch just restores the execs, which must have gone missing at some point, and without which we are excluding sh's writes instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant