-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFData instances? #283
Comments
Sure is. Been meaning to add them for a while, so I'll do it sometime over the weekend. |
Unfortunately due to the use of conduit for some request/response types, |
Let me know if this will cover your use case @gregwebs, and I'll look at cutting a release pending some other minor changes + CI. |
Seems like a great improvement. However, I still have many responses without instances. some of which seem like they shouldn't have anything to do with conduits.
|
Note that I cannot generate instances myself because smart constructors and exported instead of the data constructors. |
Thanks for catching that, an error on my part. d75a122 adds the expected response instances. Does your latter comment imply you'd rather see fully exported types? |
That's better! This satisfies my only current use case for fully exported types. In general it can be nice to expose them at least from an Internal module so that a user can create instances. |
I ask because it's not that I haven't exported them out of some misguided principle, it just requires some work to ensure that the |
The |
I wanted to put a retry around sending a request to AWS. Unfortunately there are no NFData instances, so it is difficult for me to confidently trap an exception.
Is it possible to automatically generate NFData instances for everything?
The text was updated successfully, but these errors were encountered: