Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support crypton #912

Closed
endgame opened this issue Jun 6, 2023 · 4 comments · Fixed by #920
Closed

Support crypton #912

endgame opened this issue Jun 6, 2023 · 4 comments · Fixed by #920
Milestone

Comments

@endgame
Copy link
Collaborator

endgame commented Jun 6, 2023

cryptonite has been forked to crypton for ongoing maintenance. We should support it with a flag, defaulting to crypton and falling back to cryptonite.

@endgame endgame added this to the 2.0 milestone Jun 6, 2023
@mbj
Copy link

mbj commented Jun 20, 2023

Why the flag? Context: I'd be happy to send a PR to do the change but would be interested to know why we'd want the flag?

@endgame
Copy link
Collaborator Author

endgame commented Jun 20, 2023

That was an initial guess, before I saw which way things were going to go in the community. I haven't had time to think much about this; are people writing their packages to support both cryptonite and crypton, or has everyone just moved over to crypton?

@mbj
Copy link

mbj commented Jun 20, 2023

So far I've seen just moves to crypton and issues that just ask to move to crypton.

none of these have so far AFAIK used a flag. (there are some more PRs unmerged as of yet, also not doing flags).

@endgame
Copy link
Collaborator Author

endgame commented Jun 20, 2023

If those projects beneath us in the depgraph don't use a flag then there's no point us doing so either. The PR should be pretty straightforward, then. Only subtlety is you might need to change the cabal.ede template and (in a separate PR, targeting your main PR) run scripts/generate --commit to rebuild the service bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants