Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using crypton #931

Merged
merged 1 commit into from
Jun 6, 2023
Merged

using crypton #931

merged 1 commit into from
Jun 6, 2023

Conversation

kazu-yamamoto
Copy link
Contributor

While cryptonite has a obvious bug, it has not been fixed for a long time.
This is because the author is now inactive in the Haskell community.
In private communication with him, I was not given the upload permission of cryptonite to Hackage.
He suggested me to fork cryponite and upload it as a different package.

So, I created crypton and uploaded it to Hackage with the bug fixed.
Also, I created new forks for x509-related packages and connection whose prefix is crypton-.
There are already uploaded to Hackage.
http2 and other network packages with the new dependency are on Hackage, too.

This PR makes wai-related packages to depend on crypton.

@kazu-yamamoto
Copy link
Contributor Author

Thanks. I will merge this PR and make new releases.

@kazu-yamamoto kazu-yamamoto merged commit 8356517 into yesodweb:master Jun 6, 2023
0 of 15 checks passed
@kazu-yamamoto kazu-yamamoto deleted the crypton branch June 6, 2023 12:55
@kazu-yamamoto
Copy link
Contributor Author

I have released warp and warp-tls.

@l29ah
Copy link

l29ah commented Jun 8, 2023

While cryptonite has a obvious bug, it has not been fixed for a long time.

Could you please link it to the discussion?

@kazu-yamamoto
Copy link
Contributor Author

Could you please link it to the discussion?

This one:

haskell-crypto/cryptonite#374

Comment on lines -11 to -13
#ifdef MIN_VERSION_x509
import Data.X509
#endif

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazu-yamamoto

Interestingly I get this error when trying to depend on Warp with the x509 flag disabled:

Network/Wai/Handler/Warp/Types.hs:10:1: error:
    Could not load module ‘Data.X509’
    It is a member of the hidden package ‘x509-1.7.7’.
    Perhaps you need to add ‘x509’ to the build-depends in your .cabal file.
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
10 | import Data.X509
   | ^^^^^^^^^^^^^^^^

@mpilgrem
Copy link

@kazu-yamamoto, do you know if there is any plan to create a crypton version of package cryptonite-conduit, which has repository https://github.com/haskell-crypto/cryptonite-conduit? I sought to follow Hpack and others and move Stack/Pantry from cryptonite to crypton, but have got stuck with cryptonite-conduit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants