Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate CreateCertificateFromCSR fixtures #500

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

m5
Copy link
Contributor

@m5 m5 commented Nov 2, 2018

When this repository is cloned on OSX, CreateCertificateFromCSR.yaml is overwritten by CreateCertificateFromCsr.yaml.

Nix uses a hash checksum to verify the repository, and with those files missing, a hash generated on OSX won't match one generated on linux.

NixOS/cabal2nix#382

The conflicting files are all empty, and CreateCertificateFromCSR seems to be the preferred variant.

@MaxGabriel
Copy link
Contributor

For users of git 2.21, this PR will also fix the following warning when cloning the repo to a case-insensitive file system:

✔︎ /p/tmp> git clone https://github.com/brendanhay/amazonka.git          16:46:10
Cloning into 'amazonka'...
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 283101 (delta 4), reused 2 (delta 2), pack-reused 283096
Receiving objects: 100% (283101/283101), 162.65 MiB | 1.10 MiB/s, done.
Resolving deltas: 100% (214271/214271), done.
Checking out files: 100% (15636/15636), done.
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'amazonka-iot/fixture/CreateCertificateFromCSR.yaml'
  'amazonka-iot/fixture/CreateCertificateFromCsr.yaml'
  'amazonka-iot/fixture/CreateCertificateFromCSRResponse.proto'
  'amazonka-iot/fixture/CreateCertificateFromCsrResponse.proto'

@purefn
Copy link

purefn commented Dec 26, 2019

@brendanhay - can we get this merged? It's making it impossible to share nix expressions for amazonka between Linux and macOS users.

@brendanhay brendanhay merged commit 0154b3b into brendanhay:develop Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants