Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an instance for PrimMonad m => PrimMonad (AWST' r m) #510

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Add an instance for PrimMonad m => PrimMonad (AWST' r m) #510

merged 2 commits into from
Feb 19, 2020

Conversation

axman6
Copy link
Contributor

@axman6 axman6 commented Jan 15, 2019

Adds an instance for PrimMonad AWST', which is used for low level memory access when IO or ST is the base monad in a transformer stack. The particular use case we came across was after the release of conduit 1.3 broke everything changed how IO is handled by using MonadUnliftIO, the conduit-extra changed its Zlib compression functions from needing

(MonadBaseControl b m, PrimMonad b) => ...

to needing

PrimMonad m => ...

This change doesn't actually change the packages needed to compile amazonka as primitive was already a transitive dependency.

@axman6
Copy link
Contributor Author

axman6 commented Jan 15, 2019

Ha, looks like this is a dupe of #471, both are nearly identical so happy with either (I did search for an issue asking about PrimMonad but didn't search PRs, oops 😬 ) @LeifW

@brendanhay brendanhay merged commit 303fa74 into brendanhay:develop Feb 19, 2020
@axman6
Copy link
Contributor Author

axman6 commented Feb 19, 2020

Thanks @brendanhay! ❤️

@LeifW LeifW mentioned this pull request Feb 19, 2020
@brendanhay
Copy link
Owner

Apologies @LeifW - I was working in descending PR order 🤷‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants