Update service definitions for cloudwatch-events #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add some paginators and some networking features that appear to be required for using this service with Fargate.
MichaelXavier
added a commit
to Soostone/amazonka
that referenced
this pull request
Aug 23, 2019
This branch can be removed when/if PR brendanhay#544 is merged. It includes generated code, which is discouraged from going in PRs. Still, to depend on our fork we need the generated code, hence this branch.
|
Tested this out today and it looks like it works. @brendanhay I've got my own fork with the codegen applied. How should we go about doing the codegen for this project? Given that releases are kind of painful, we'd probably want to do an across-the-board update of service definition files. |
brendanhay
pushed a commit
that referenced
this pull request
Jul 27, 2020
This branch can be removed when/if PR #544 is merged. It includes generated code, which is discouraged from going in PRs. Still, to depend on our fork we need the generated code, hence this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add some paginators and some networking features that appear to
be required for using this service with Fargate.
I tried to follow the advice of
gen/README.mdand only committed the changes to the service files. LMK if this wasn't right. We're due for a dozen or two other service updates but I wanted to make my MR minimal.