Replace generate.nix with in-tree generator script #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endgame
approved these changes
Sep 28, 2021
Comment on lines
+40
to
+43
| cabal-fmt = { | ||
| inherit (pkgs.cabalProject) index-state; | ||
| version = "0.1.5.1"; | ||
| }; |
There was a problem hiding this comment.
Can we use pkgs.haskellPackages.cabal-fmt in buildInputs, or is that version too old?
There was a problem hiding this comment.
If we use pkgs.haskellPackages.cabal-fmt we need to potentially download another GHC from the cache - by using tools it ensures it uses the same (patched) GHC from haskell.nix.
|
I'll try and do the audit functionality in a separate pass - probably by exposing the previous diffs (available services in botocore vs services in configs/services) as attributes from |
brendanhay
added a commit
that referenced
this pull request
Sep 29, 2021
Adds the rest of the previous generate.nix functionality removed by #639
brendanhay
added a commit
that referenced
this pull request
Sep 29, 2021
Adds the rest of the previous generate.nix functionality removed by #639
brendanhay
added a commit
that referenced
this pull request
Sep 29, 2021
Adds the rest of the previous generate.nix functionality removed by #639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current iteration of
generate.nixsomewhat moronically copies a bunch of unnecessary paths (like, the whole repo) in/out of/nix/storecausing it to eat a bunch of disk space.This PR replaces most of the logic from
generate.nixwith an equivalent inscript/generate, using anix-shellshebang and GNU parallel to marginally speed up the formatting phase. The audit step which was used to diff what services were un/implemented has been skipped for now.