Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#651] Allow 'profile ' in ~/.aws/config file sections #654

Merged

Conversation

korayal
Copy link
Contributor

@korayal korayal commented Sep 30, 2021

closes #651

@korayal korayal force-pushed the 651-allow-profile-prefix-for-config branch from 86d187b to c0e0609 Compare September 30, 2021 10:46
@endgame endgame added this to the 2.0 RC 1 milestone Sep 30, 2021
@endgame
Copy link
Collaborator

endgame commented Sep 30, 2021

The code does not compile but the intent seems to be pointing in the right direction. I'll have to read up on the details of the config format AWS uses before coming back to this.

@endgame endgame self-assigned this Sep 30, 2021
@endgame
Copy link
Collaborator

endgame commented Sep 30, 2021

Alternatively, if you can fix the compile errors and then ping me before then, I'll be happy to take another look. Thanks for the PR.

@korayal korayal changed the title [#651] Allow 'profile ' in ~/.aws/config file sections WIP: [#651] Allow 'profile ' in ~/.aws/config file sections Sep 30, 2021
@korayal
Copy link
Contributor Author

korayal commented Sep 30, 2021 via email

@korayal korayal force-pushed the 651-allow-profile-prefix-for-config branch from c0e0609 to 84d9c45 Compare September 30, 2021 12:56
@korayal korayal changed the title WIP: [#651] Allow 'profile ' in ~/.aws/config file sections [#651] Allow 'profile ' in ~/.aws/config file sections Sep 30, 2021
@korayal korayal force-pushed the 651-allow-profile-prefix-for-config branch from 84d9c45 to f39ffa4 Compare September 30, 2021 13:06
@korayal
Copy link
Contributor Author

korayal commented Sep 30, 2021

@endgame I think now this should be good to go, but I have one concern. I can't find the exact documentation on this, but it looks like for named profiles the profile prefix is mandatory, whereas it is not for default.

I wonder if sections like profile default and otherprofile (or even having more than one whitespace between profile and the profile name) are going to be an issue.

I heard from colleagues where stripping profile prefix from sections inside ~/.aws/config does not play well with awscli. So, I've updated the PR to have that prefix for named profiles.

@endgame
Copy link
Collaborator

endgame commented Sep 30, 2021

I'll get to it as soon as I can. Meanwhile, can you please rebase against latest develop and add an entry to amazonka/CHANGELOG.md?

@korayal korayal force-pushed the 651-allow-profile-prefix-for-config branch from 7350c6f to c9d77d1 Compare September 30, 2021 19:23
@korayal korayal force-pushed the 651-allow-profile-prefix-for-config branch from c9d77d1 to 367888e Compare September 30, 2021 19:25
@korayal
Copy link
Contributor Author

korayal commented Sep 30, 2021

done.

@endgame endgame merged commit 5ad346c into brendanhay:develop Oct 3, 2021
@endgame
Copy link
Collaborator

endgame commented Oct 3, 2021

@korayal thank you for this.

@korayal korayal deleted the 651-allow-profile-prefix-for-config branch October 4, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amazonka terminates when there is a profile prefix in ~/.aws/config's sections
4 participants