amazonka-rds: Support DestinationRegion pseudo-parameter #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shlevy If you're still around, would be great to see if this works for you. Run |
Cross-region replication on RDS is performed by making a request against the _destination_ region. In that request, you need to pass a `PreSignedUrl` for the _source_ region, with the `DestionationRegion` parameter set to the _destination_ region. There are five such requests at the moment, specified by https://github.com/boto/botocore/blob/77359646878e261eaa9debad888fc8f3b20832ef/botocore/data/rds/2014-10-31/service-2.sdk-extras.json These specify a `SourceRegion` parameter because botocore rearranges the rds requests internally, stripping `SourceRegion` from the request itself and injecting a `DestinationRegion` parameter into the `PreSignedUrl` field: https://github.com/boto/botocore/blob/ec0eb680d6e6e753c7d7ddf0242b8ae1c3b38db5/botocore/handlers.py#L1080-L1089 Fixes brendanhay#378
endgame
force-pushed
the
rds-cross-region-pseudoparameter
branch
from
efe27dc
to
a394e05
Compare
|
Given #379 , this extra field is probably completely useless unless you sub in a different signer by hand, so it's probably worth merging now and fixing the rest later. |
|
@endgame Makes sense, |
|
@endgame Apologies, not using amazonka in active projects at the moment |
|
@shlevy no worries, thanks for stopping by. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-region replication on RDS is performed by making a request
against the destination region. In that request, you need to pass a
PreSignedUrlfor the source region, with theDestionationRegionparameter set to the destination region.
There are five such requests at the moment, specified by
https://github.com/boto/botocore/blob/77359646878e261eaa9debad888fc8f3b20832ef/botocore/data/rds/2014-10-31/service-2.sdk-extras.json
These specify a
SourceRegionparameter because botocore rearrangesthe rds requests internally, stripping
SourceRegionfrom the requestitself and injecting a
DestinationRegionparameter into thePreSignedUrlfield:https://github.com/boto/botocore/blob/ec0eb680d6e6e753c7d7ddf0242b8ae1c3b38db5/botocore/handlers.py#L1080-L1089
Fixes #378