Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 mandatory multipart upload ids #725

Merged

Conversation

endgame
Copy link
Collaborator

@endgame endgame commented Dec 2, 2021

As before, this is forked from #723 so I have a changelog to work in.

Since it's the main point of calling this API, we can safely assume
its presence.

https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/model/InitiateMultipartUploadResult.html#getUploadId--

> Contains the results of initiating a multipart upload, particularly
> the unique ID of the new multipart upload.
Since it's the main point of calling this API, we can safely assume
its presence.

https://docs.aws.amazon.com/amazonglacier/latest/dev/api-multipart-initiate-upload.html

> Amazon S3 Glacier (S3 Glacier) creates a multipart upload resource
> and returns its ID in the response.
@endgame
Copy link
Collaborator Author

endgame commented Dec 2, 2021

@axman6 FYI

@endgame endgame added this to the 2.0 milestone Dec 2, 2021
@brendanhay brendanhay merged commit 97f71a2 into brendanhay:main Dec 2, 2021
@endgame endgame deleted the s3-mandatory-multipart-upload-ids branch December 5, 2021 23:39
@endgame
Copy link
Collaborator Author

endgame commented Dec 5, 2021

Reported upstream: boto/botocore#2572

S3's stance [the AWS team maintaining the service] on seemingly required output fields is to mark them as optional, as output is something the user cannot control. I did inquire about changing them since it seemed to cause some confusion, but they declined to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants