Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSM: Require more fields #741

Merged
merged 1 commit into from Dec 21, 2021
Merged

SSM: Require more fields #741

merged 1 commit into from Dec 21, 2021

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Dec 21, 2021

These were tested by trying the commands put-parameter, get-parameter
and get-parameters with awscli.

 % aws ssm put-parameter --name test-dec-20 --value "abc" --type String
{
    "Version": 1
}
 % aws ssm get-parameter --name test-dec-20                            
{
    "Parameter": {
        "Version": 1,
        "Value": "abc",
        "Type": "String",
        "Name": "test-dec-20"
    }
}
 % aws ssm get-parameters --names test-dec-20
{
    "Parameters": [
        {
            "Name": "test-dec-20",
            "Value": "abc",
            "Type": "String",
            "Version": 1
        }
    ],
    "InvalidParameters": []
}
 % aws ssm get-parameters --names test-dec-21
{
    "InvalidParameters": [
        "test-dec-21"
    ],
    "Parameters": []
}
 % aws ssm delete-parameter --name test-dec-20 
 % aws ssm delete-parameter --name test-dec-20

An error occurred (ParameterNotFound) when calling the DeleteParameter operation:

Fixes #740.

@ysangkok
Copy link
Contributor Author

I am unsure of the naming, and I don't know how to verify it since I can't get Bazel working. Is it GetParameterResult or GetParameterResponse? configs/annexes/ssm.json uses Result but the source code uses Response. Same goes for the other names.

@endgame
Copy link
Collaborator

endgame commented Dec 21, 2021

You'll want to use the names of the shapes in botocore when writing out typeOverrides. The generator normalises a bunch of different conventions from different services when generating the names of Haskell types.

Could you please also add a changelog entry?

These were tested by trying the commands put-parameter, get-parameter
and get-parameters with awscli.
@ysangkok
Copy link
Contributor Author

Ok, added!

@endgame
Copy link
Collaborator

endgame commented Dec 21, 2021

Thanks!

@endgame endgame merged commit e64638a into brendanhay:main Dec 21, 2021
@ysangkok ysangkok deleted the ssm-required-value branch December 21, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssm: Is the Value field on Parameter required?
2 participants