Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handwitten lenses in service bindings #859

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Handwitten lenses in service bindings #859

merged 4 commits into from
Dec 8, 2022

Conversation

endgame
Copy link
Collaborator

@endgame endgame commented Dec 8, 2022

Fixes #846

Tristano8
Tristano8 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@Tristano8 Tristano8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question

lib/services/amazonka-s3/src/Amazonka/S3/Internal.hs Outdated Show resolved Hide resolved
@endgame endgame force-pushed the handwitten-lenses-in-service-bindings branch 2 times, most recently from 4039d36 to 8fb3e8f Compare December 8, 2022 22:49
@endgame endgame force-pushed the handwitten-lenses-in-service-bindings branch from 8fb3e8f to d055396 Compare December 8, 2022 22:50
@endgame endgame merged commit c2bde42 into brendanhay:main Dec 8, 2022
@endgame endgame deleted the handwitten-lenses-in-service-bindings branch December 8, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristano8 Tristano8 Tristano8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename handwritten optics to match new convention
2 participants
@endgame @Tristano8