Gen sorted interfaces #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to retrieve field names etc in sorted order. Timings: with Data.Map.Strict real 2m0.380s user 1m56.609s sys 0m3.100s with Data.HashMap.Strict real 2m0.435s user 1m56.775s sys 0m3.017s
This makes explicit the effect of using Map instead of HashMap: that all fields are emitted in sorted order.
|
It seems unlikely that aeson will gain the ability to do sorted |
I did not try the branch. But determinism that does not depend on an implementation artifact (that in case of Given we cannot (easily) retain the source field order ATM, I think sorting by field name is the best compromise. |
michaelwebb76
approved these changes
Dec 12, 2022
This was referenced Jan 17, 2023
endgame
added a commit
to endgame/amazonka
that referenced
this pull request
Jan 17, 2023
Same output as brendanhay#862, but sticks to `HashMap` internally to avoid triggering https://github.com/brendanhay/amazonka/issue/888 A couple of enums change value in a strange way, because the generator cannot handle enums-of-numeric values. See brendanhay#889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the generator from
HashMaptoMap, which means that all thetoListcalls come out in sorted order. This will keep the ordering of fields predictable and should give us better diffs in future generator runs.While it might be nice to follow botocore's ordering for struct fields, I can't see a good way to do that: haskell/aeson#984
A full regeneration is on the
endgame:gen-sorted-interfaces-genbranch (#863). Please try it and let me know if you think this is better than the arbitrary "howeverHashMap.toListsorted them" that we used to have.Closes #825 .