Per shape timestamp format #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endgame
approved these changes
Jan 11, 2023
divarvel
force-pushed
the
per-shape-timestamp-format
branch
from
18ddab3
to
282a94e
Compare
This commits lets shape definitions carry a `timestampFormat` field, allowing to override the service defaults, as supported by botocore: boto/botocore#1507
divarvel
force-pushed
the
per-shape-timestamp-format
branch
from
282a94e
to
c96973e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #881
timestampFormatwas not supported in shapes definitionstimestampFormatis supported in service metadata but not used anywhere (neither botocore nor amazonka annexes) (it was quickly checked by turning it into aMaybe Void; no parse error was triggered)This PR adds support for reading it in shape definition and removes support from reading it from service metadata.