do not force MonadIO on presign

[avieth]

No description provided.

[endgame]

Since withAuth still has to have a MonadIO constraint, I'm curious what this is buying you. I see it's coming from a workplace fork, which means it's proven necessary for something, so I'm happy to merge it with a couple of tweaks.

In addition to the suggestions inline, there's a couple more changes I'll need to see before I can merge it, but those are minor:

• Add an entry to lib/amazonka/CHANGELOG.md
• Re-export withAuth from Amazonka.Auth (as a general rule, most normal users should not have to depend directly on amazonka-core)

[avieth]

Since withAuth still has to have a MonadIO constraint, I'm curious what this is buying you. I see it's coming from a workplace fork, which means it's proven necessary for something, so I'm happy to merge it with a couple of tweaks.

In our application we always make an AuthEnv available by other means, never using the Ref constructor of Auth. So this patch just buys us more flexibility/predictability: it's better to not have IO in the type since we never do any. The old definitions which may use IO can all be defined in terms of these pure alternatives, so it seems like a better factoring.

I'll make the suggested changes.

[endgame]

I agree that it's a better factoring, and I hope we can merge it before I tag RC2.

[avieth]

Should be good to go now. LMK if I missed anything.

[endgame]

Couple of final nits, but I look forward to merging this today if you have time to make the changes.

[endgame]

Thank you very much.