Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic Rhs parameter for traits and structs and generalize implementations for [T] #48

Merged
merged 3 commits into from
Jan 13, 2019
Merged

Add generic Rhs parameter for traits and structs and generalize implementations for [T] #48

merged 3 commits into from
Jan 13, 2019

Commits on Jan 11, 2019

  1. Add generic Rhs parameter for *Eq traits 

    This makes them match `std::cmp::PartialEq`. It's also necessary to
make it possible to implement the `*Eq` traits for some combinations
of types, such as `ndarray::ArrayBase<S, D>` instances of differing
storage `S` (e.g. owned and view).
    @jturner314
    jturner314 committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    5d12593 View commit details
    Browse the repository at this point in the history

  2. Implement *Eq traits for slices of differing types

    @jturner314
    jturner314 committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    09b679c View commit details
    Browse the repository at this point in the history

  3. Add right-hand-side type parameter to structs 

    This is necessary for the macros to function correctly when the left
and right hand sides have different types.
    @jturner314
    jturner314 committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    e589ac7 View commit details
    Browse the repository at this point in the history