Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for configuring the number of lines of source snippet around a label #29

Closed
brendanzab opened this issue Jul 6, 2018 · 5 comments

Comments

@brendanzab
Copy link
Owner

This would allow us to give users more context of problems.

Here is an example from Reason:

@Johann150
Copy link
Collaborator

Is this related to #125 ?

@elkowar
Copy link
Contributor

elkowar commented Aug 2, 2021

Would be great if this was implemented. Is there anything specific holding this back? If not, I'd be open to trying myself at a PR for this

@elkowar
Copy link
Contributor

elkowar commented Aug 2, 2021

I wrote up a mock implementation in elkowar@fa4d5f8
This is most likely a pretty bad way to do this, although I'm not sure how i'd improve it - I'm really not familiar with the codebase. Any hints and thoughts would be appreciated!

@Johann150
Copy link
Collaborator

Hmm, I think that would be the place to implement it, but not sure if its the best way, will have too look more into the code base again. But for a proper review you should open a pull request!

@Johann150
Copy link
Collaborator

I think this issue was resolved with #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants