Add option for including context before and after a label #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann150
requested changes
Aug 6, 2021
There was a problem hiding this comment.
Hi, thanks for your contribution. I am not sure your code does what the issue asks for. See the below more specific comments for that.
As per the Quality Standards outlined in the Contribution Guidelines I would (also) ask you to please include some tests for this added functionality.
elkowar
force-pushed
the
surrounding-lines
branch
from
fa4d5f8
to
8683b52
Compare
|
I added a test to verify the implementation, and fixed the code in the view logic! 😄 |
- use checked_sub in favour of unclear usize::min - remove `rev` because it does the opposite of what it was supposed to do - add some comments
Johann150
approved these changes
Aug 9, 2021
mbartlett21
pushed a commit
to mbartlett21/codespan
that referenced
this pull request
Oct 28, 2021
…#331) * Add option for including context before and after a label * simplify logic: - use checked_sub in favour of unclear usize::min - remove `rev` because it does the opposite of what it was supposed to do - add some comments Co-authored-by: Johann150 <johann.galle@protonmail.com>
|
When will this be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #29!
I'm not sure that this is the best way to implement this, as i'm not all that deep into the codebase. If necessary, i'd appreciate any suggestions or tips on how to improve this!