Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marker padding #14

Merged
merged 3 commits into from Apr 16, 2018
Merged

Fix marker padding #14

merged 3 commits into from Apr 16, 2018

Conversation

brendanzab
Copy link
Owner

I broke the padding in c1a382e due to my misunderstanding of what was going on. I've created a new Pad datatype to make it clearer.

Following rustc's lead I've also:

  • made the secondary labels use a different styling to the primary labels,
  • used blue coloring rather than cyan for the line numbers

@brendanzab brendanzab merged commit 983990a into master Apr 16, 2018
@brendanzab brendanzab deleted the fix-marker-padding branch April 16, 2018 06:56
@Marwes
Copy link
Collaborator

Marwes commented Apr 16, 2018

So the blue styling is actually rather dark which makes it hard to see on dark terminals (at least on mine) which is why I used cyan instead as that is what ripgrep uses. rustc does not use either of those colors though if we want to use that same as it.

@Marwes
Copy link
Collaborator

Marwes commented Apr 16, 2018

@brendanzab
Copy link
Owner Author

Ah, interesting! Are you on windows then?

@Marwes
Copy link
Collaborator

Marwes commented Apr 16, 2018

Yep, but using Git Bash which seems to still have the issue (but it might just be my colorscheme, need to double check that actually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants