Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing scope is inconsistent based on add_new_at #138

Closed
k1w1 opened this issue Nov 10, 2014 · 2 comments
Closed

Changing scope is inconsistent based on add_new_at #138

k1w1 opened this issue Nov 10, 2014 · 2 comments

Comments

@k1w1
Copy link

k1w1 commented Nov 10, 2014

If add_new_at is set to bottom then items moved into a list because of scope changes are added at the requested position. If add_new_at is set to top then the items are always added at the top, regardless of the requested position.

This is important when you have a grid of items and want to support dragging between lists. In our use-case it makes more sense for add_to_list_top to work the same way as add_to_list_bottom and to respect the existing value of the position column. This would mean that truly new items would be added to the top, but items dragged between lists would stay in the position you dragged them to (because the position is already set).

k1w1 added a commit to k1w1/acts_as_list that referenced this issue Nov 10, 2014
This makes the behavior consistent with add_new_at: :bottom and fixes brendon#138.
@swanandp
Copy link
Collaborator

This sounds like a bug, if you open a pull request, I can merge this.

@brendon
Copy link
Owner

brendon commented Jul 15, 2016

Closing due to no one wanting to pursue this anymore. Could still be an obscure bug.

@brendon brendon closed this as completed Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants