Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATION WARNING on rails 5.0 as of acts_as_list 0.9 #251

Closed
jhawthorn opened this issue Jan 24, 2017 · 3 comments
Closed

DEPRECATION WARNING on rails 5.0 as of acts_as_list 0.9 #251

jhawthorn opened this issue Jan 24, 2017 · 3 comments

Comments

@jhawthorn
Copy link
Contributor

Since upgrading to 0.9.0, I've been seeing this deprecation error on Rails 5.0.1:

DEPRECATION WARNING: #table_exists? currently checks both tables and views. This behavior is deprecated and will be changed with Rails 5.1 to only check tables. Use #data_source_exists? instead.

The call to table_exists was added here

@brendon
Copy link
Owner

brendon commented Jan 24, 2017

Thanks @jhawthorn :)

@zharikovpro would you mind looking into how we can avoid this warning? Should just be a fork in the logic there I guess. I think we may have already done this elsewhere in the code already.

@zharikovpro
Copy link
Contributor

@brendon yes, will take a look and prepare PR. Should be an easy fix.

zharikovpro added a commit to zharikovpro/acts_as_list that referenced this issue Jan 25, 2017
@brendon
Copy link
Owner

brendon commented Jan 26, 2017

All fixed @jhawthorn :) Thanks again @zharikovpro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants