Refactor column definer module #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename column -> position_column to make it clear what kind of column we're talking about.
|
I am generally skeptical about merging pure refactoring PRs, unless they serve a specific purpose. But this refactoring is looking good, and makes the code a lot more readable. @brendon Unless you have any objections, we can merge this. |
swanandp
approved these changes
Feb 27, 2017
IlkhamGaysin
pushed a commit
to IlkhamGaysin/acts_as_list
that referenced
this pull request
Mar 1, 2017
* master: Refactor column definer module (brendon#258) Fix deprecation introduced in ActiveRecord 5.1. Add rails 5.1.0.beta1 and ruby 2.4 to test matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up
ColumnMethodDefiner- extract some methods and other changes.