Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use database mutex locking #359

Closed
wants to merge 4 commits into from
Closed

Conversation

Silex
Copy link
Contributor

@Silex Silex commented Sep 2, 2019

Make sure to read #325 first.

@brendon
Copy link
Owner

brendon commented Sep 2, 2019

Hi @Silex, good to see you active on this again. I've been working on the repo today cleaning up the tests on travis (dropping Rails 3.2-4.1 support and old ruby support) so be sure to check out master.

@brendon
Copy link
Owner

brendon commented Sep 2, 2019

Also, don't edit the gemfiles directly, edit Appraisals instead.

@Silex
Copy link
Contributor Author

Silex commented Sep 2, 2019

@brendon: not really working on this, just recreating the PR because I had deleted my fork but was able to recover the commits.

@brendon
Copy link
Owner

brendon commented Sep 2, 2019

Thanks @Silex, that's all good :)

@c2ofh
Copy link

c2ofh commented Nov 15, 2020

Could this PR maybe could fix the DeadLock-Problem? @brendon

@brendon
Copy link
Owner

brendon commented Nov 15, 2020

Hi @c2ofh, this one kind of languished. If you'd like to create a new PR based off this and get the tests green then I'd definitely look at it. Key here will be making it an opt-in thing as it could have wide reaching consequences on some codebases.

@brendon brendon closed this Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants