fixed memoization of RankedModel::Ranker::Mapper#finder #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a value for each passed sort order; without this multiple calls to finder can cause weird flipping issues where whole list gets reversed
mpokrywka
added a commit
to mpokrywka/ranked-model
that referenced
this pull request
Sep 7, 2016
|
When updating position using ":up", "update_index_from_position" calls "find_previous_two" which calls "finder" with ":desc" parameter - and causes finder to be memoized with descending order which causes problems when rebalance is called when saving. This should fix #103, I added test 37e19f8 which demonstrates problem (moving up and rebalance because positions are consecutive without gaps) and is fixed by this PR |
This was referenced May 1, 2017
Closed
|
This has now been fixed by #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed memoization of RankedModel::Ranker::Mapper#finder; it now caches a value for each passed sort order; without this multiple calls to finder can cause weird flipping issues where whole list gets reversed.
May be related to issue mentioned here: #103