Make rearrange_ranks resilient to race conditions #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In less strict isolation levels, the first or last row according to the ranking may disappear after a rank conflict is identified, but before rearranging occurs. Allow for approximate ordering in this case. Serializable isolation level should still guarantee strict ordering. undefined method `rank' for nil:NilClass [GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model/ranker.rb:177 :in `rearrange_ranks` [GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model/ranker.rb:166 :in `assure_unique_position` [GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model/ranker.rb:61 :in `handle_ranking` [GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model.rb:31 :in `block in handle_ranking` [GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model.rb:30 :in `each` [GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model.rb:30 :in `handle_ranking`
|
probably related to #124 |
|
Could this be rebased to see if the current version has the fault? |
|
Thanks for finding all these old tickets @fschwahn :) I was never keen on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In less strict isolation levels, the first or last row according to the ranking
may disappear after a rank conflict is identified, but before rearranging
occurs. Allow for approximate ordering in this case.
Serializable isolation level should still guarantee strict ordering.
undefined method `rank' for nil:NilClass
[GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model/ranker.rb:177 :in
rearrange_ranks[GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model/ranker.rb:166 :in
assure_unique_position[GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model/ranker.rb:61 :in
handle_ranking[GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model.rb:31 :in
block in handle_ranking[GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model.rb:30 :in
each[GEM_ROOT]/gems/ranked-model-0.4.0/lib/ranked-model.rb:30 :in
handle_ranking