Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float type not compiling properly, missing crate? #51

Closed
yoroshikun opened this issue Apr 30, 2022 · 2 comments
Closed

Float type not compiling properly, missing crate? #51

yoroshikun opened this issue Apr 30, 2022 · 2 comments

Comments

@yoroshikun
Copy link

This issue is kinda split into two

  1. Float seems to be using a external crate, this possibly needs to be documented as its not included with the crate
  2. Even with the crate it seems that from_f64 is not working, is it meant to be this one? Here
                Self::ChanceNot(value) => (
                    "chance".to_string(),
                    SerializedWhereValue::Object(vec![(
                        "not".to_string(),
                        PrismaValue::Float(bigdecimal::from_f64(value).unwrap().normalized()) // <-- This bigdecimal
                            .into(),
                    )]),
                ),
@Brendonovich
Copy link
Owner

Whoops, I forgot to make primsa_client_rust re-export bigdecimal. Would you mind using rev = 7b103ca7e422d2d5a8935818407fc0023f1b3ab8 instead of tag = "0.4.1" to try out the fix I pushed? It should also fix #50

@yoroshikun
Copy link
Author

thanks for the fast reply testing them now!

This issue has been resolved by that commit, however #50 still persists. Will post more info there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants