Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Bar Redesign #71

Closed
SerhiiCho opened this issue Aug 13, 2023 · 4 comments · Fixed by #78
Closed

Navigation Bar Redesign #71

SerhiiCho opened this issue Aug 13, 2023 · 4 comments · Fixed by #78
Labels
ux/ui Issues and PRs related to UX/UI design

Comments

@SerhiiCho
Copy link
Collaborator

We can change a navigation bar to something like this:

image

Here are some things that we can do related to the nav bar:

  1. We can add a PHP logo since this platform is specific for php
  2. We can change the font for "rfc votes" logo (later we can make a custom logo)
  3. We can change the color of the navbar to dark blue to make more PHP related
  4. The navigation bar itself has to have a nav HTML elements instead of the regular div.
  5. We can add a container inside the navigation bar to fix the issue on the screenshot below that appears on wide screens:

image

We can make this dark blue as the main accent color and use it for other elements to make it look more consistent with colors.

I'd like to hear what others think about this.

@brendt
Copy link
Owner

brendt commented Aug 14, 2023

We can add a PHP logo since this platform is specific for php

I think we need to be careful though: people might think this is an official PHP project, which is not the case.

We can change the font for "rfc votes" logo (later we can make a custom logo)

Makes sense to make a logo at one point (as well as a favicon) — I might ask a designer at JetBrains soon. I don't think we need a cursive font as a temporary placeholder.

We can change the color of the navbar to dark blue to make more PHP related

Isn't purple closer to PHP though? Right now we're using the default Tailwind colors, I'm not against changing it. I choose purple though exactly because of PHP.

The navigation bar itself has to have a nav HTML elements instead of the regular div.

Seems like a good idea 👍

We can add a container inside the navigation bar to fix the issue on the screenshot below that appears on wide screens:

Yes, we should definitely do that 👍

@SerhiiCho
Copy link
Collaborator Author

SerhiiCho commented Aug 14, 2023

What about this version?:

image
  1. Added showing which link is active
  2. Changed the user profile link
  3. Reduced the vertical padding on the navbar
  4. Added container inside the navbar to make it look nice on widescreens
  5. Change HTML tag of the navbar from <div></div> to <nav></nav>

I haven't touched the mobile version, currently it looks like this with these changes:

image

@brendt
Copy link
Owner

brendt commented Aug 14, 2023

Oh I like that! Could you send a PR? :)

@brendt brendt added the ux/ui Issues and PRs related to UX/UI design label Aug 14, 2023
@SerhiiCho
Copy link
Collaborator Author

Thanks, I just pushed a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/ui Issues and PRs related to UX/UI design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants