Adds watching for less files -- closes #10 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildScripts/buildLess.js
Outdated
| @@ -9,6 +9,7 @@ import fs from 'fs'; | |||
| import less from 'less'; | |||
| import mkdirp from 'mkdirp'; | |||
| import path from 'path'; | |||
| import chokidar from 'chokidar'; | |||
buildScripts/buildLess.js
Outdated
| console.log(chalk.red('--watch not yet implemented')); | ||
| process.exit(1); | ||
| chokidar.watch(PATH_TO_WATCH).on('all', (event, path) => { | ||
| if (event === "add" || event === "change") { |
There was a problem hiding this comment.
would prefer a switch statement instead of a series of if statments
buildScripts/buildLess.js
Outdated
| console.log(chalk.blue(event, path)); | ||
| compileLessAndWriteToCSSFile(path) | ||
| .then(() => { | ||
| console.log(chalk.green('Done compiling ' + path)); |
There was a problem hiding this comment.
Use template strings:
`Done compiling ${path}`
buildScripts/buildLess.js
Outdated
| console.log(chalk.red('--watch not yet implemented')); | ||
| process.exit(1); | ||
| chokidar.watch(PATH_TO_WATCH).on('all', (event, path) => { | ||
| if (event === "add" || event === "change") { |
There was a problem hiding this comment.
no double quotes, only single quotes
brenmcnamara
requested changes
Apr 29, 2017
buildScripts/buildLess.js
Outdated
| console.log(chalk.green('Done compiling ' + path)); | ||
| }); | ||
| } | ||
| if (event === "unlink") { |
buildScripts/buildLess.js
Outdated
| const cssMapFilename = Stylesheets.getDistCSSMapFileForLessFile(path); | ||
| Promise.all([removeFile(cssFilename), removeFile(cssMapFilename)]); | ||
| } | ||
| if (event === "unlinkDir") { |
buildScripts/buildLess.js
Outdated
| const cssFilepath = Stylesheets.getDistCSSPathForLessPath(path); | ||
| removePath(cssFilepath); | ||
| } | ||
| if (event === "addDir" && path !== PATH_TO_WATCH) { |
brenmcnamara
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.